Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testSeqNoCollision #52154

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix testSeqNoCollision #52154

merged 1 commit into from
Feb 11, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 10, 2020

We roll a new translog generation and trim operations that are above the global checkpoint during primary-replica resync. If the initOperations is empty, then the stale operation on the replica2 will be discarded as it is the only operation in a translog file (since #51905 where we started using the local checkpoint to calculate the minimum required translog generation for recovery). Otherwise, the stale op will be retained along with initOperations but will be skipped in snapshots.

Relates #51905
Closes #52148

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v7.7.0 labels Feb 10, 2020
@dnhatn dnhatn requested a review from ywelsch February 10, 2020 16:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Feb 11, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit 0b493e5 into elastic:master Feb 11, 2020
@dnhatn dnhatn deleted the fix-seqno-collision branch February 11, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Failure in IndexLevelReplicationTests.testSeqNoCollision
4 participants